# HG changeset patch # User Mike Hommey # Date 1559648384 0 # Node ID 71d3424191f63751068077270a32f9f3aeb026b8 # Parent 590b5ea9aa8ae57750fcd3ff9c789f6acf40266c Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor In a branch for `isinstance(obj, (HostSources, HostGeneratedSources))`, `isinstance(obj, GeneratedSources)` is clearly not going to match anything. `isinstance(obj, HostGeneratedSources)` is what was intended. Differential Revision: https://phabricator.services.mozilla.com/D33603 diff --git a/python/mozbuild/mozbuild/backend/recursivemake.py b/python/mozbuild/mozbuild/backend/recursivemake.py --- a/python/mozbuild/mozbuild/backend/recursivemake.py +++ b/python/mozbuild/mozbuild/backend/recursivemake.py @@ -481,17 +481,17 @@ class RecursiveMakeBackend(CommonBackend backend_file.write('%s += %s\n' % (var, f)) elif isinstance(obj, (HostSources, HostGeneratedSources)): suffix_map = { '.c': 'HOST_CSRCS', '.mm': 'HOST_CMMSRCS', '.cpp': 'HOST_CPPSRCS', } variables = [suffix_map[obj.canonical_suffix]] - if isinstance(obj, GeneratedSources): + if isinstance(obj, HostGeneratedSources): variables.append('GARBAGE') base = backend_file.objdir else: base = backend_file.srcdir for f in sorted(obj.files): f = mozpath.relpath(f, base) for var in variables: backend_file.write('%s += %s\n' % (var, f))