# HG changeset patch
# User Zibi Braniecki <zbraniecki@mozilla.com>
# Date 1527047369 25200
# Node ID 541a8cda26a5fbdd18b260385b55fd95dca0ce9e
# Parent  6791a28fc2039de576671e05ee90c2ae2df43487
Bug 1453765 - Switch Fluent from warning to throwing errors when in debug/testing mode. r=Gijs

MozReview-Commit-ID: 1y7FTCPWRxb

diff --git a/browser/components/preferences/in-content/privacy.xul.1453765.later b/browser/components/preferences/in-content/privacy.xul.1453765.later
new file mode 100644
--- /dev/null
+++ b/browser/components/preferences/in-content/privacy.xul.1453765.later
@@ -0,0 +1,21 @@
+--- privacy.xul
++++ privacy.xul
+@@ -223,17 +223,17 @@
+       </radiogroup>
+     </vbox>
+     <vbox>
+       <!-- Please don't remove the wrapping hbox/vbox/box for these elements. It's used to properly compute the search tooltip position. -->
+       <hbox>
+         <button id="clearSiteDataButton"
+             class="accessory-button"
+             icon="clear"
+-            search-l10n-ids="clear-site-data-cookies, clear-site-data-cache"
++            search-l10n-ids="clear-site-data-cookies-empty.label, clear-site-data-cache-empty.label"
+             data-l10n-id="sitedata-clear"/>
+       </hbox>
+       <hbox>
+         <button id="siteDataSettings"
+                 class="accessory-button"
+                 data-l10n-id="sitedata-settings"
+                 search-l10n-ids="
+                   site-data-settings-window.title,
diff --git a/browser/components/preferences/siteDataSettings.js.1453765.later b/browser/components/preferences/siteDataSettings.js.1453765.later
new file mode 100644
--- /dev/null
+++ b/browser/components/preferences/siteDataSettings.js.1453765.later
@@ -0,0 +1,21 @@
+--- siteDataSettings.js
++++ siteDataSettings.js
+@@ -33,17 +33,17 @@ let gSiteDataSettings = {
+     // Creates a new column item with the specified relative width.
+     function addColumnItem(l10n, flexWidth) {
+       let box = document.createElement("hbox");
+       box.className = "item-box";
+       box.setAttribute("flex", flexWidth);
+       let label = document.createElement("label");
+       label.setAttribute("crop", "end");
+       if (l10n) {
+-        if (l10n.raw) {
++        if (l10n.hasOwnProperty("raw")) {
+           box.setAttribute("tooltiptext", l10n.raw);
+           label.setAttribute("value", l10n.raw);
+         } else {
+           document.l10n.setAttributes(label, l10n.id, l10n.args);
+         }
+       }
+       box.appendChild(label);
+       container.appendChild(box);
diff --git a/intl/l10n/DOMLocalization.jsm b/intl/l10n/DOMLocalization.jsm
--- a/intl/l10n/DOMLocalization.jsm
+++ b/intl/l10n/DOMLocalization.jsm
@@ -606,17 +606,20 @@ class DOMLocalization extends Localizati
       }
     }
 
     // This fragment allows us to coalesce all pending translations
     // into a single requestAnimationFrame.
     if (this.pendingElements.size > 0) {
       if (this.pendingrAF === null) {
         this.pendingrAF = this.windowElement.requestAnimationFrame(() => {
-          this.translateElements(Array.from(this.pendingElements));
+          // We need to filter for elements that lost their l10n-id while
+          // waiting for the animation frame.
+          this.translateElements(Array.from(this.pendingElements)
+            .filter(elem => elem.hasAttribute("data-l10n-id")));
           this.pendingElements.clear();
           this.pendingrAF = null;
         });
       }
     }
   }
 
   /**
@@ -680,17 +683,20 @@ class DOMLocalization extends Localizati
           for (let i = 0; i < overlayTranslations.length; i++) {
             if (overlayTranslations[i] !== undefined &&
                 untranslatedElements[i] !== undefined) {
               translateElement(untranslatedElements[i], overlayTranslations[i]);
             }
           }
           this.resumeObserving();
         })
-        .catch(() => this.resumeObserving());
+        .catch(e => {
+          this.resumeObserving();
+          throw e;
+        });
     }
     return this.translateElements(this.getTranslatables(frag));
   }
 
   /**
    * Translate a list of DOM elements asynchronously using this
    * `DOMLocalization` object.
    *
diff --git a/intl/l10n/Localization.jsm b/intl/l10n/Localization.jsm
--- a/intl/l10n/Localization.jsm
+++ b/intl/l10n/Localization.jsm
@@ -150,19 +150,22 @@ class Localization {
 
     for await (const ctx of this.ctxs) {
       const missingIds = keysFromContext(method, ctx, keys, translations);
 
       if (missingIds.size === 0) {
         break;
       }
 
-      if (AppConstants.NIGHTLY_BUILD) {
+      if (AppConstants.NIGHTLY_BUILD || Cu.isInAutomation) {
         const locale = ctx.locales[0];
         const ids = Array.from(missingIds).join(", ");
+        if (Cu.isInAutomation) {
+          throw new Error(`Missing translations in ${locale}: ${ids}`);
+        }
         console.warn(`Missing translations in ${locale}: ${ids}`);
       }
     }
 
     return translations;
   }
 
   /**
diff --git a/intl/l10n/test/dom/test_domloc_overlay_missing_all.html b/intl/l10n/test/dom/test_domloc_overlay_missing_all.html
--- a/intl/l10n/test/dom/test_domloc_overlay_missing_all.html
+++ b/intl/l10n/test/dom/test_domloc_overlay_missing_all.html
@@ -22,21 +22,21 @@
   addLoadEvent(async () => {
 
     const domLoc = new DOMLocalization(
       window,
       [],
       mockGenerateMessages
     );
 
-    await domLoc.translateFragment(document.body);
-
-    // we just care that it doesn't throw here.
-    ok(1);
-
+    await domLoc.translateFragment(document.body).then(() => {
+      ok(false, "Expected translateFragment to throw on missing l10n-id");
+    }, () => {
+      ok(true, "Expected translateFragment to throw on missing l10n-id");
+    });
     SimpleTest.finish();
   });
   </script>
 </head>
 <body>
   <p data-l10n-id="title">
     <a href="http://www.mozilla.org"></a>
     <a href="http://www.firefox.com"></a>