# HG changeset patch # User Frank-Rainer Grahl # Date 1621294471 -7200 # Parent 60d9785974bcdb4d90621d9de143a5bda2c4f1cd Bug 1909864 - Remove unimplemented PickNextCell. r=IanN a=IanN diff --git a/db/mork/public/mdb.h b/db/mork/public/mdb.h --- a/db/mork/public/mdb.h +++ b/db/mork/public/mdb.h @@ -2307,23 +2307,16 @@ public: // { ----- begin cell iteration methods ----- NS_IMETHOD NextCell( // get next cell in the row nsIMdbEnv* ev, // context nsIMdbCell** acqCell, // changes to the next cell in the iteration mdb_column* outColumn, // column for this particular cell mdb_pos* outPos) = 0; // position of cell in row sequence - NS_IMETHOD PickNextCell( // get next cell in row within filter set - nsIMdbEnv* ev, // context - nsIMdbCell* ioCell, // changes to the next cell in the iteration - const mdbColumnSet* inFilterSet, // col set of actual caller interest - mdb_column* outColumn, // column for this particular cell - mdb_pos* outPos) = 0; // position of cell in row sequence - // Note that inFilterSet should not have too many (many more than 10?) // cols, since this might imply a potential excessive consumption of time // over many cursor calls when looking for column and filter intersection. // } ----- end cell iteration methods ----- // } ===== end nsIMdbRowCellCursor methods ===== }; diff --git a/db/mork/src/morkRowCellCursor.cpp b/db/mork/src/morkRowCellCursor.cpp --- a/db/mork/src/morkRowCellCursor.cpp +++ b/db/mork/src/morkRowCellCursor.cpp @@ -214,27 +214,12 @@ morkRowCellCursor::NextCell( // get next *outPos = pos; if ( outColumn ) *outColumn = col; mRowCellCursor_Col = pos; return NS_OK; } -NS_IMETHODIMP -morkRowCellCursor::PickNextCell( // get next cell in row within filter set - nsIMdbEnv* mev, // context - nsIMdbCell* ioCell, // changes to the next cell in the iteration - const mdbColumnSet* inFilterSet, // col set of actual caller interest - mdb_column* outColumn, // column for this particular cell - mdb_pos* outPos) -// Note that inFilterSet should not have too many (many more than 10?) -// cols, since this might imply a potential excessive consumption of time -// over many cursor calls when looking for column and filter intersection. -{ - NS_ASSERTION(false, "not implemented"); - return NS_ERROR_NOT_IMPLEMENTED; -} - // } ----- end cell iteration methods ----- // } ===== end nsIMdbRowCellCursor methods ===== diff --git a/db/mork/src/morkRowCellCursor.h b/db/mork/src/morkRowCellCursor.h --- a/db/mork/src/morkRowCellCursor.h +++ b/db/mork/src/morkRowCellCursor.h @@ -61,23 +61,16 @@ public: // morkRowCellCursor constructio // { ----- begin cell iteration methods ----- NS_IMETHOD NextCell( // get next cell in the row nsIMdbEnv* ev, // context nsIMdbCell** acqCell, // changes to the next cell in the iteration mdb_column* outColumn, // column for this particular cell mdb_pos* outPos) override; // position of cell in row sequence - NS_IMETHOD PickNextCell( // get next cell in row within filter set - nsIMdbEnv* ev, // context - nsIMdbCell* ioCell, // changes to the next cell in the iteration - const mdbColumnSet* inFilterSet, // col set of actual caller interest - mdb_column* outColumn, // column for this particular cell - mdb_pos* outPos) override; // position of cell in row sequence - // Note that inFilterSet should not have too many (many more than 10?) // cols, since this might imply a potential excessive consumption of time // over many cursor calls when looking for column and filter intersection. // } ----- end cell iteration methods ----- private: // copying is not allowed morkRowCellCursor(const morkRowCellCursor& other);